Mantis clean up - you can help too!

(previously 'DEVELOPER') Private forum for registered community members. To register, please visit www.prison-architect.com/register.

Moderator: NBJeff

RGeezy911
level5
level5
Posts: 1098
Joined: Fri Aug 09, 2013 7:21 pm

Re: Mantis spring cleaning - you can help too!

Postby RGeezy911 » Mon Jun 02, 2014 9:13 am

Couldn't sleep... Decided to get on Mantis... Potatoes...

#312 - Resolved
#313 - Resolved - Cannot reproduce.
#324 - Resolved
#331 - Resolved - Cannot reproduce.
#333 - Resolved - Cannot reproduce.
#350 - Resolved
#351 - Resolved - Cannot reproduce.
#364 - Resolved - Cannot reproduce.
#369 - Resolved
#370 - Resolved
#371 - Resolved - Cannot reproduce.
#391 - Resolved
#396 - Resolved
#400 - Resolved
______________________________
#401 - Resolved
#421 - Resolved - Cannot reproduce.
#427 - Resolved
#452 - Resolved
#462 - Resolved
#466 - Resolved
#469 - Opened - Still is an issue.
#470 - Resolved
#477 - Resolved
#483 - Closed - Not a bug.
#484 - Resolved - Duplicate of #370
#485 - Resolved
#488 - Resolved
#491 - Resolved - Cannot reproduce.
#493 - Resolved - Cannot reproduce.
#498 - Resolved - Cannot reproduce.

Reef wrote:If someone could pat me on the back, it would be appreciated.

If I had three hands and arms, I'd pat you on the back and applaud you at the same time.
Last edited by RGeezy911 on Mon Jun 02, 2014 10:50 am, edited 1 time in total.
Reason: Editing #469.
User avatar
xander
level5
level5
Posts: 16869
Joined: Thu Oct 21, 2004 11:41 pm
Location: Highland, CA, USA
Contact:

Re: Mantis spring cleaning - you can help too!

Postby xander » Mon Jun 02, 2014 3:40 pm

Reef, you are a monster. I would pat you on the back, but I failed telekenesis 301 last year, and since it wasn't required for my degree, I chose not to retake it.

xander
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Mon Jun 02, 2014 8:32 pm

RGeezy911, could you please stop reopening clones that I close?
ex. http://bugs.introversion.co.uk/view.php?id=4237#c7345
http://bugs.introversion.co.uk/view.php?id=4234#c7349

This one is also interesting:
http://bugs.introversion.co.uk/view.php?id=278#c7604

You even clapped and patted me on the back on the same time regarding this issue :roll:
RGeezy911
level5
level5
Posts: 1098
Joined: Fri Aug 09, 2013 7:21 pm

Re: Mantis spring cleaning - you can help too!

Postby RGeezy911 » Mon Jun 02, 2014 9:01 pm

I now have updater status, so here is a small list of reports I have marked resolved:

#526 - Resolved
#527 - Resolved
#528 - Resolved
#538 - Resolved
#552 - Resolved
#567 - Resolved
#580 - Resolved
#593 - Resolved - Cannot reproduce.
#598 - Resolved
#611 - Resolved
#626 - Resolved
______________________________
Also closed many duplicates / clones for one particular report:

http://bugs.introversion.co.uk/view.php?id=2883 - Dupe
http://bugs.introversion.co.uk/view.php?id=2884 - Dupe
http://bugs.introversion.co.uk/view.php?id=2885 - Dupe
http://bugs.introversion.co.uk/view.php?id=2886 - Dupe
http://bugs.introversion.co.uk/view.php?id=2887 - Dupe
http://bugs.introversion.co.uk/view.php?id=2888 - Dupe
http://bugs.introversion.co.uk/view.php?id=2889 - Dupe
http://bugs.introversion.co.uk/view.php?id=2890 - Dupe
http://bugs.introversion.co.uk/view.php?id=2891 - Dupe
http://bugs.introversion.co.uk/view.php?id=2892 - Dupe
http://bugs.introversion.co.uk/view.php?id=2893 - Dupe
http://bugs.introversion.co.uk/view.php?id=2894 - Dupe
http://bugs.introversion.co.uk/view.php?id=2895 - Dupe
http://bugs.introversion.co.uk/view.php?id=2896 - Dupe
http://bugs.introversion.co.uk/view.php?id=2897 - Kept open as it contains an attachment.

I will continue to mark my progress on this topic.
______________________________
Reef wrote:RGeezy911, could you please stop reopening clones that I close?
ex. http://bugs.introversion.co.uk/view.php?id=4237#c7345
http://bugs.introversion.co.uk/view.php?id=4234#c7349

This one is also interesting:
http://bugs.introversion.co.uk/view.php?id=278#c7604

You even clapped and patted me on the back on the same time regarding this issue :roll:

Hi Reef,

Please check your PM inbox.
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Tue Jun 03, 2014 1:13 am

We have smashed 350 bugs! AWESOME!

Now lets smash even more. Keep posting issue ids which you deal with so we can keep the counter. I am saving it all and keeping score for everyone just in case we need it later.

Targeted assignments are here. I'm adding to them.

Make sure you mark issues as duplicates with a relation before you close them. We will later use an automated analysis tool to crawl all existing issues and give us information about which issues cause a lot of duplicates and then we'll be able to analyze that. Hopefully some useful knowledge can be retrieved from that. One could imagine a tool which would work sort of like the reporting form on StackOverflow which, as you type, searches for similar issues so that you are notified about it before you post. Mantis doesn't have an online capability of doing so, but we could have an offline deduplication tool which would work in the same manner, letting us keep the future duplicates on a very low level for a very little effort. But in order to teach the tool, we need each issue to be marked as duplicate/child/etc with a relation.
User avatar
xander
level5
level5
Posts: 16869
Joined: Thu Oct 21, 2004 11:41 pm
Location: Highland, CA, USA
Contact:

Re: Mantis spring cleaning - you can help too!

Postby xander » Tue Jun 03, 2014 1:16 am

Reef (and anyone else who may be interested): I have made progress on O7, but I cannot claim to be actively working on it during the week---I have classes to teach, papers to grade, and so on. I think I have the first 10 results pretty well nailed down, but there are 115 left to go, and I would like to invite everyone else to work on them in the meantime. If not, I'll try to spend another couple of hours on them next weekend.

xander
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Tue Jun 03, 2014 1:21 am

@xander, hint: only look on the issues which really involve food, not on all of the issues which have been found by the filter. The others will be catched by some other filter or something.
b0rk
level1
level1
Posts: 12
Joined: Sun Sep 15, 2013 5:29 pm

Re: Mantis spring cleaning - you can help too!

Postby b0rk » Tue Jun 03, 2014 2:22 am

More AI chef / food bugs
http://bugs.introversion.co.uk/view.php?id=3940
http://bugs.introversion.co.uk/view.php?id=3706
http://bugs.introversion.co.uk/view.php?id=2808
http://bugs.introversion.co.uk/view.php?id=2479
http://bugs.introversion.co.uk/view.php?id=2121
2121, 2479, 2808, 3940 and 3706 are dupes of 2217

http://bugs.introversion.co.uk/view.php?id=4265 << new AI chef issue?
http://bugs.introversion.co.uk/view.php?id=3838 << no sure if AI chef or wider multiple of bug
http://bugs.introversion.co.uk/view.php?id=3155 << fixed alpha 16
http://bugs.introversion.co.uk/view.php?id=1169 << multiple of bug *again* duped against 2217?
http://bugs.introversion.co.uk/view.php?id=2403 << dupe of 0004356, Objects can be used outside of the appropriate room
http://bugs.introversion.co.uk/view.php?id=2253 << multiple of bug *again* duped against 2217?

http://bugs.introversion.co.uk/view.php?id=1233 << haven't seen this ages assume fixed?
http://bugs.introversion.co.uk/view.php?id=3439 dupe of 1233
http://bugs.introversion.co.uk/view.php?id=2346 dupe of 1233


Would a multiple of... mother bug make sense to tag up the items under M1 or should they all get duped against 2217 as AI Chef which Chris seems to be working on? mantis has lots of reports relating to multiple canteens, kitchens, laundries, Infirmaries, Morgues not being balanced in terms of matching demand against need.


Any chance of a path finding mother bug as there are loads of path related issues and potential dupes, there is probably a shared root cause behind the pathing issues.
User avatar
_alphaBeta_
level4
level4
Posts: 534
Joined: Sun Jul 21, 2013 2:20 pm
Location: NJ, USA

Re: Mantis spring cleaning - you can help too!

Postby _alphaBeta_ » Tue Jun 03, 2014 4:22 am

I'm going to start targeting the laundry (04 on the assignments).

b0rk wrote:Any chance of a path finding mother bug as there are loads of path related issues and potential dupes, there is probably a shared root cause behind the pathing issues.

Certainly makes sense. If you leave me a list in this thread, I'll start linking these together as well. I'll leave the cook / food assignment to someone else as I haven't personally experimented much with this aspect of the game.

As a side note, we could use some more feedback with anyone having issues with dogs going into kennels again. See Mantis Artifact ID 3467 and kindly post your findings.
User avatar
xander
level5
level5
Posts: 16869
Joined: Thu Oct 21, 2004 11:41 pm
Location: Highland, CA, USA
Contact:

Re: Mantis spring cleaning - you can help too!

Postby xander » Tue Jun 03, 2014 3:39 pm

Prison Architect does not support non-Latin and accented characters. This results in crashes when such characters are in the save path, and prevents translations in to many languages (the bugs marked with an asterisk are related to translations, the rest are crashes):
Mother bug: #379
Open duplicates and related bugs:

xander

EDIT: Another duplicate of http://bugs.introversion.co.uk/view.php?id=96 (the wall phasing bug) was posted today: http://bugs.introversion.co.uk/view.php?id=4411 .
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Tue Jun 03, 2014 11:19 pm

We have smashed 360 bugs! AWESOME!

Now lets smash even more. Keep posting issue ids which you deal with so we can keep the counter. I am saving it all and keeping score for everyone just in case we need it later.

Targeted assignments are here. I'm adding to them. I just added some easy assignments from a bot.


b0rk wrote:...

@b0rk, thank you for participating in our project!
I have closed 7 of the issues which you have listed, but you advised to close more. Please be very careful. Sometimes it is better to leave a bug as related to another one or as a child of another one if the issue is similar but a bit different. It is often important to developers to have a view on a bug from multiple angles. If the angle is exactly the same, it is a duplicate, but if it is even slightly different, it should have some other type of relationship than duplicate. I'm sure You'll get a good grasp of it once you get some experience. Please see the issues which you have linked and take a look at what I have done with them. The fact that you have discovered the issues related to cooking helped greatly.

As for the mother bug you think is necessary, I think it is a wonderful idea. Mind 0002457 though. Please feel free to create a motherbug yourself and post a link to it and links of child issues so that we can link them to your ticket.

----
all of the issues (except for assignments of course) up until this point are taken care of
mazetar
level2
level2
Posts: 141
Joined: Mon Feb 11, 2013 12:14 am

Re: Mantis spring cleaning - you can help too!

Postby mazetar » Wed Jun 04, 2014 5:42 am

I got a few minutes free, so I'm starting to work through the BOT ASSIGNMENTS.
I'll report back in a short while when I have done the list :)
mazetar
level2
level2
Posts: 141
Joined: Mon Feb 11, 2013 12:14 am

Re: Mantis spring cleaning - you can help too!

Postby mazetar » Wed Jun 04, 2014 7:02 am

So I've completed the BOT assignments
BOT001 -> BOT005.
All current BOT assignments.
The bottom of this post contains a summary of every assignment and what I observed.

I've found that the bot did find some duplicates, so it's on the right track.
It did however miss on some occasions, where the issues where not related by other than the affected type/category/keyword.

Most of the things it found was Double posts by the same reporter.
It seems that double posting is SUPER-COMMON when trying to upload files, often the Reporter is unaware of this.
If the uploaded file is invalid for any reason, the user is asked to use the BACK button and re-do the upload and re-submit the report.
This causes there to often be almost identical reports, one with a file and one without one.

Often these reports will have sequential ID's, like the below example:
4199
4198 -- Duplicates, double post by Reporter.

Therefore it should be possible to let a bot crawl through the reports in order, and flag any which has the same reporter as the last report.
This should flag both reports together, for easy manual comparison to confirm later.


Overall I must say that the bot did a good job, at the same time as I did this I read notes and thereby closed a few extras as well.
3 of the issue groups where totally unrelated to each other.
1 group was not duplicates, but related.
2 groups where probably duplicates, but due to lack of info they where set as related.
So this helped out quite a lot! :)


== Summary of Assignment ==

Other

BOT001 - Fatal Error:
http://bugs.introversion.co.uk/view.php?id=0002980
http://bugs.introversion.co.uk/view.php?id=0004084
http://bugs.introversion.co.uk/view.php?id=0003305
http://bugs.introversion.co.uk/view.php?id=0002903

Might be the same for all 4, but due to poor descriptions it's hard to be sure.
It's the same error message, and the same crash location (file & line number).
Likely to be the same bug, but possible that there are more issues.
I don't feel confident in closing them as duplicates.

Found http://bugs.introversion.co.uk/view.php?id=2850 which has developer response.
While searching I quickly found a whole bunch of these issues.
I'm not closing them, and I think it's best we nest these together as an assignment to be gathered into a Motherbug.

Duplicates

BOT001 - Workers stop working.:
http://bugs.introversion.co.uk/view.php?id=0003888
http://bugs.introversion.co.uk/view.php?id=0003044 - Duplicates

BOT003 - object placement:
http://bugs.introversion.co.uk/view.php?id=0004250
http://bugs.introversion.co.uk/view.php?id=0004074 - Duplicates.


BOT005 - Crash while paused:
http://bugs.introversion.co.uk/view.php?id=0000594
http://bugs.introversion.co.uk/view.php?id=0000319 -- Duplicates, although because of Technical crash specs are important setting to Related.
-- These are really old, I'm sure investigation will reveal several similar issues, and most likely this has been flagged as solved in one of them.


Duplicates - Double posts
BOT001 - Prison is blocking the road, truck traffic jam:
http://bugs.introversion.co.uk/view.php?id=0002963
http://bugs.introversion.co.uk/view.php?id=0002964 -- Duplicates, double post by Reporter.

BOT002 - The prisoners have stopped moving:
http://bugs.introversion.co.uk/view.php?id=0003792
http://bugs.introversion.co.uk/view.php?id=0003791 -- Duplicates, double post by Reporter.

BOT002 - Huge slowdown of the game when prisoners working in a kitchen have nothing to do.:
http://bugs.introversion.co.uk/view.php?id=0002802
http://bugs.introversion.co.uk/view.php?id=0002803 -- Duplicates, double post by Reporter.

BOT002 - AI freezes:
http://bugs.introversion.co.uk/view.php?id=0002800
http://bugs.introversion.co.uk/view.php?id=0002799 -- Duplicates, double post by Reporter.

BOT003 - The workers don't move, finish their jobs or start to build the new room:
http://bugs.introversion.co.uk/view.php?id=0002634
http://bugs.introversion.co.uk/view.php?id=0002644 -- Duplicates, double post by Reporter.

BOT003 - Cost to hire guard/dog/armed guard is not displayed as being higher after researching tazer-rollout/body armour.:
http://bugs.introversion.co.uk/view.php?id=0004199
http://bugs.introversion.co.uk/view.php?id=0004198 -- Duplicates, double post by Reporter.

BOT004 - Game crashes:
http://bugs.introversion.co.uk/view.php?id=0002946
http://bugs.introversion.co.uk/view.php?id=0002947 -- Duplicates, double post by Reporter.

BOT004 - More staff exhausted than exist:
http://bugs.introversion.co.uk/view.php?id=0004246
http://bugs.introversion.co.uk/view.php?id=0004245 -- Duplicates, double post by Reporter.

BOT005 - Wall won't be destroyed:
http://bugs.introversion.co.uk/view.php?id=0004145
http://bugs.introversion.co.uk/view.php?id=0004144 -- Duplicates, double post by Reporter.

BOT005 - The dead body fall down from a ambulance - cannot be taken:
http://bugs.introversion.co.uk/view.php?id=0003176
http://bugs.introversion.co.uk/view.php?id=0003177 -- Duplicates, double post by Reporter.


Related
BOT003 - Store *X in *Y:
http://bugs.introversion.co.uk/view.php?id=0002282
http://bugs.introversion.co.uk/view.php?id=0003074 -- Related, probably duplicates but lack of info prevents certanty.

BOT004:
BOT004 - Workers:
http://bugs.introversion.co.uk/view.php?id=0003101
http://bugs.introversion.co.uk/view.php?id=0002809 -- Related, probably duplicates but unclear info prevents certanty.

BOT004 - Deployment:
http://bugs.introversion.co.uk/view.php?id=0002920
http://bugs.introversion.co.uk/view.php?id=0002506 -- Related.


Unrelated
BOT001 - Laundry:
http://bugs.introversion.co.uk/view.php?id=0003993
http://bugs.introversion.co.uk/view.php?id=0003256 -- Different issues, both involving Laundry. The first is a wellknown bug, the other may be user error, lacks information.

BOT002 - Contraband:
http://bugs.introversion.co.uk/view.php?id=0001476
http://bugs.introversion.co.uk/view.php?id=0003436 -- Different issues, both involving contraband.

BOT005 - Jobs:
http://bugs.introversion.co.uk/view.php?id=0002806
http://bugs.introversion.co.uk/view.php?id=0001499 -- Unrelated.
Last edited by mazetar on Wed Jun 04, 2014 10:14 am, edited 1 time in total.

Return to “Community Members”

Who is online

Users browsing this forum: No registered users and 0 guests