Mantis clean up - you can help too!

(previously 'DEVELOPER') Private forum for registered community members. To register, please visit www.prison-architect.com/register.

Moderator: NBJeff

Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Mantis clean up - you can help too!

Postby Reef » Sat May 31, 2014 3:52 pm

quick links:
Mantis bug database is filled with bug duplicates.

Introversion has stated recently that they will fix bugs soon, but the more time they spend sifting through thousands of bugs in attempt to find useful information, the less time they will spend on actually fixing them, right?

In order to help, you need a Mantis account. This is not the same as forum account. John explains how to create a Mantis account here.

There are about 3000 bugs in Mantis already. Many of them are duplicates or issues that have been resolved a long time ago. I have closed 40 bugs as duplicates and such in a couple of hours and I keep at it, but there are only 4 people with permissions and expertise necessary to do this and the bugfix month has only 30 days. Here is what You can do to help:

  1. If you can find groups of bug duplicates and post links to them in this thread, it would really help me and other moderators
  2. If you would find an issue which you can not reproduce anymore, comment on it saying that you can't reproduce on Alpha-21 and link the bug in this thread.
  3. If you would find an issue which has unclear reproduction steps and it doesn't seem to happen in Alpha-21, link the bug in this thread, so we can ask the reporter if it still occurs (and we'll change the state to "Feedback". If nobody will answer for a week, there is not much that IV can do with it, so it'll get closed)
  4. If you would find a feature request which has not Severity field set to feature, link it here.

You can find examples on how to report in the next post.

There are also some targeted assignments available if you think you can handle it. See here for the first batch of'em.

----

Technical details of deduplication procedure (you don't have to read unless you are a Mantis moderator):

How to decide which bug is to be closed as duplicate and which should remain open?
  • If one of the bugs in the family has a "Target version" field set, it means IV has looked on a bug, understood it and planned to fix it, so this will stay open and the others will be deduplicated. This is the most important rule.
  • The voting system is important. If a bug is in top20 vote-wise, we'll close the other ones to respect and preserve votes.
  • The industry standard is to assume that the bug which has been reported first is the original and the rest are duplicates
  • Sometimes the first bug reported has very low quality of description because people didn't really know back then what causes the bug, they could only see the effect. In that case description may be improved or we can just deduplicate to the bug which has the best description.
Generally it has to be carefully considered, but not for too long, because there are 3000 bugs and 29 days left. So let's get to work.
Last edited by RGeezy911 on Tue Jul 01, 2014 10:00 pm, edited 3 times in total.
Reason: Changing topic title. Changing topic type to sticky.
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Sat May 31, 2014 3:53 pm

Bug duplicate family: (Some) Prisoners won't attend Reform Programs
http://bugs.introversion.co.uk/view.php?id=4190
http://bugs.introversion.co.uk/view.php?id=4191
http://bugs.introversion.co.uk/view.php?id=4193 <-- this one has best description
the 3 above are almost identical. Other in the same family:
http://bugs.introversion.co.uk/view.php?id=3598
http://bugs.introversion.co.uk/view.php?id=3732
http://bugs.introversion.co.uk/view.php?id=4039 (not 100% sure, description is unclear)

Bug duplicate family: manufacturing grant progress counter decrements
http://bugs.introversion.co.uk/view.php?id=4005 (superior bed)
http://bugs.introversion.co.uk/view.php?id=3713 (superior bed)
http://bugs.introversion.co.uk/view.php?id=3731 (superior bed)
http://bugs.introversion.co.uk/view.php?id=3842 (superior bed)
http://bugs.introversion.co.uk/view.php?id=3846 (superior bed)
http://bugs.introversion.co.uk/view.php?id=4026 (license plates)
the bug in the code is the same for beds and plates, just occurs more frequently for beds. New issue was filed to reflect that:
http://bugs.introversion.co.uk/view.php?id=4267 <--- this one has the best description


Not bugs, but change/feature discussions/requests which don't belong in Mantis but on forums or something:
http://bugs.introversion.co.uk/view.php?id=3661

http://bugs.introversion.co.uk/view.php?id=4196

Unclear what the issue is:
http://bugs.introversion.co.uk/view.php?id=2166

Very low quality report (many issues, unclear):
http://bugs.introversion.co.uk/view.php?id=4081
mazetar
level2
level2
Posts: 141
Joined: Mon Feb 11, 2013 12:14 am

Re: Mantis spring cleaning - you can help too!

Postby mazetar » Sat May 31, 2014 6:35 pm

Great idea, I've spent some time giving duplicates the "duplicate" tag and writing notes linking to what seems to be the most relevant issue.

Heres group I recall from earlier today at least:

Laundry baskets - Can't dismantle/sell them.
http://bugs.introversion.co.uk/view.php?id=1984 - Active Issue
http://bugs.introversion.co.uk/view.php?id=2591
http://bugs.introversion.co.uk/view.php?id=2527
http://bugs.introversion.co.uk/view.php?id=2138
http://bugs.introversion.co.uk/view.php?id=3061
http://bugs.introversion.co.uk/view.php?id=3450
http://bugs.introversion.co.uk/view.php?id=3042

Also while looking for these I found:
http://bugs.introversion.co.uk/view.php?id=2775 which is noted to be a duplicate of http://bugs.introversion.co.uk/view.php?id=1311
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Sat May 31, 2014 7:11 pm

@mazetar: Unfortunately the duplicate tag can not be deleted from an issue by people with Updater permissions, so if anyone ever makes a mistake in using it, it will be there forever. This makes filtering issues by the duplicate tag unreliable.

You have just closed 18 bugs. Well done, keep at it :)
mazetar
level2
level2
Posts: 141
Joined: Mon Feb 11, 2013 12:14 am

Re: Mantis spring cleaning - you can help too!

Postby mazetar » Sat May 31, 2014 7:30 pm

That sucks :P
Well when we use this thread, then it's not to much need for it to be used anyways I guess :)

Reef wrote:You have just closed 7 bugs. Well done, keep at it :)
EDIT: oh, you made even more :)

As a programming student I found that comment to be rather funny ;)
And quite true :P

Edit:
Also, I mentioned some cloned issues in the PM I sent you earlier, the issues weren't just duplicates they had the exact same notes and everything else except the ID's.
Do you have any idea what's up with those?
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Sat May 31, 2014 7:40 pm

Unfortunately I do. I will contact John immediately.
WarpedPerspectiv
level1
level1
Posts: 74
Joined: Sun Mar 09, 2014 8:08 am

Re: Mantis spring cleaning - you can help too!

Postby WarpedPerspectiv » Sat May 31, 2014 8:24 pm

I'd love to help, but I'm unable to access the bug tracker. Trying to sign in just leaves me on the login screen with my info still in the boxes. Filed a support ticket but have yet to hear back.
User avatar
xander
level5
level5
Posts: 16869
Joined: Thu Oct 21, 2004 11:41 pm
Location: Highland, CA, USA
Contact:

Re: Mantis spring cleaning - you can help too!

Postby xander » Sat May 31, 2014 8:27 pm

acegamer08
level3
level3
Posts: 425
Joined: Sat Feb 23, 2013 6:13 pm

Re: Mantis spring cleaning - you can help too!

Postby acegamer08 » Sat May 31, 2014 8:52 pm

3000 bugs, 21 days (3 weeks work-1 week off)... no way you going to get anywhere near 3k bugs fixed, unless about 2900 are duplicates.
RGeezy911
level5
level5
Posts: 1098
Joined: Fri Aug 09, 2013 7:21 pm

Re: Mantis spring cleaning - you can help too!

Postby RGeezy911 » Sat May 31, 2014 9:48 pm

I'm gonna start looking for bug reports that have since been resolved / fixed to try and help you out on that side of Mantis.

Here's a few off the beginning:
#2 - Resolved
#7 - Might be reproduced on certain systems. I can't reproduce; it works fine on my end.
#25 - Resolved
#41 - Resolved
#47 - Resolved
#50 - Resolved
#52 - Resolved - Chris has posted on this report, user is using an old OS version / unsupported.
#60 - Resolved
#63 - Cannot reproduce, little to no information.
#64 - Resolved

Gotta clean Mantis up guys, so help Reef out and post any dupes you may find!
mazetar
level2
level2
Posts: 141
Joined: Mon Feb 11, 2013 12:14 am

Re: Mantis spring cleaning - you can help too!

Postby mazetar » Sat May 31, 2014 10:36 pm

acegamer08 wrote:3000 bugs, 21 days (3 weeks work-1 week off)... no way you going to get anywhere near 3k bugs fixed, unless about 2900 are duplicates.


Considering that
- There are many non-duplicate issues related to the same type of code/logic.
- Many bug reports are from old versions, which means many are already resolved but not marked as such!
- The focus is to fix the most important bugs as seen by the devs and by the community.

Then it's not that impossible a task :)
To have the game bugfree in 21days however is impossible, but that goes for any bigger piece of software ;)

Having a updated and clean bug database speeds things up quite a bit!


Edit: Also http://bugs.introversion.co.uk/view.php?id=4187 duplicate as described in it's note.
RGeezy911
level5
level5
Posts: 1098
Joined: Fri Aug 09, 2013 7:21 pm

Re: Mantis spring cleaning - you can help too!

Postby RGeezy911 » Sat May 31, 2014 11:07 pm

Here's some more:

#69 - Resolved
#74 - Resolved - Intended function of the game.
#80 - Resolved - Can no longer build on road.
#83 - Resolved
#87 - Resolved
#93 - Resolved - The AI will eventually re-route.
#101 - Mostly Resolved - The Bureaucracy, Clone and Grading buttons still have this issue.
#104 - Resolved - Cooks are much more efficient now.
#118 - Resolved
#135 - Resolved - Cannot reproduce.
Reef
level2
level2
Posts: 83
Joined: Fri Jul 05, 2013 9:12 pm

Re: Mantis spring cleaning - you can help too!

Postby Reef » Sun Jun 01, 2014 12:40 am

We have smashed 152 bugs! Good work!

Now lets smash even more.

I'll be going to sleep soon, so I'll leave some hints below on what you could work. Before you start working on it though, here's the procedure:
  1. See if someone didn't already started working on it, so 2 people don't do the same work. We have no time to waste.
  2. If nobody started yet, reply quoting the assignment and saying that you are doing it
  3. When you finish, edit your post and add the results of your work

What Mother Bugs are?
We now have created a "Mother Bugs" for:It will let us navigate between bugs (and deduplicate them) better and also by grouping things together we'll make work for Chris and John easier. Imagine you'd want to fix things thare are not saving, but had no Mother Bug for it - it'd take an hour from bugfixing to get that from search or code review. We have no IV-developer time to waste.


Assignments:

(undone assignments were moved here),

R1 (done by RGeezy911):
Check if http://bugs.introversion.co.uk/view.php?id=291 is reproducible on the newest Alpha or resolved?
Check if http://bugs.introversion.co.uk/view.php?id=718 is reproducible on the newest Alpha or resolved?
Check if http://bugs.introversion.co.uk/view.php?id=885 is reproducible on the newest Alpha or resolved?
Check if http://bugs.introversion.co.uk/view.php?id=1539 is reproducible on the newest Alpha or resolved?

R2 (done by RGeezy911 and xander who ninja'd each other. Watch out for ninjas!)
Check if http://bugs.introversion.co.uk/view.php?id=942 is reproducible on the newest Alpha or resolved?

O1 (done by RGeezy911):
Bugs related to http://bugs.introversion.co.uk/view.php?id=104 should be reviewed, there is a hint that some of them are resolved or duplicate.
Bugs related to http://bugs.introversion.co.uk/view.php?id=137 should be reviewed, there is a hint that some of them are resolved or duplicate.
Bugs related to http://bugs.introversion.co.uk/view.php?id=163 should be reviewed, there is a hint that some of them are resolved or duplicate.

O4 (being done by _alphaBeta_):
View bugs with status in {new, acknowledged, confirmed, assigned}, severity NOT "feature", resolution {open, reopened}, show: 500, search: laundry. Report duplicates/resolved, find motherbugs etc

O6 (done by Mazetar):
View bugs with status in {new, acknowledged, confirmed, assigned}, severity NOT "feature", resolution {open, reopened}, show: 500, search: morgue. Report duplicates/resolved, find motherbugs etc

O7 (xander is working on them):
View bugs with status in {new, acknowledged, confirmed, assigned}, severity NOT "feature", resolution {open, reopened}, show: 500, search: food. Report duplicates/resolved, find motherbugs etc

Below are hints/assignments from a bot
Currently the bot doesn't think much. For now it sees issues with identical titles and that usually means that such issue is a duplicate, but not always. Please review and find out if it was right or wrong and report in the thread.

BOT001 (done by Mazetar):
Workers stop working.:
http://bugs.introversion.co.uk/view.php?id=0003888
http://bugs.introversion.co.uk/view.php?id=0003044

Prison is blocking the road, truck traffic jam:
http://bugs.introversion.co.uk/view.php?id=0002963
http://bugs.introversion.co.uk/view.php?id=0002964

Fatal Error:
http://bugs.introversion.co.uk/view.php?id=0002980
http://bugs.introversion.co.uk/view.php?id=0004084
http://bugs.introversion.co.uk/view.php?id=0003305
http://bugs.introversion.co.uk/view.php?id=0002903

Laundry:
http://bugs.introversion.co.uk/view.php?id=0003993
http://bugs.introversion.co.uk/view.php?id=0003256

BOT002 (done by Mazetar):
The prisoners have stopped moving:
http://bugs.introversion.co.uk/view.php?id=0003792
http://bugs.introversion.co.uk/view.php?id=0003791

Contraband:
http://bugs.introversion.co.uk/view.php?id=0001476
http://bugs.introversion.co.uk/view.php?id=0003436

Huge slowdown of the game when prisoners working in a kitchen have nothing to do.:
http://bugs.introversion.co.uk/view.php?id=0002802
http://bugs.introversion.co.uk/view.php?id=0002803

AI freezes:
http://bugs.introversion.co.uk/view.php?id=0002800
http://bugs.introversion.co.uk/view.php?id=0002799

BOT003 (done by Mazetar):
object placement:
http://bugs.introversion.co.uk/view.php?id=0004250
http://bugs.introversion.co.uk/view.php?id=0004074

The workers don't move, finish their jobs or start to build the new room:
http://bugs.introversion.co.uk/view.php?id=0002634
http://bugs.introversion.co.uk/view.php?id=0002644

Cost to hire guard/dog/armed guard is not displayed as being higher after researching tazer-rollout/body armour.:
http://bugs.introversion.co.uk/view.php?id=0004199
http://bugs.introversion.co.uk/view.php?id=0004198

Store *X in *Y:
http://bugs.introversion.co.uk/view.php?id=0002282
http://bugs.introversion.co.uk/view.php?id=0003074

BOT004 (done by Mazetar):
Workers:
http://bugs.introversion.co.uk/view.php?id=0003101
http://bugs.introversion.co.uk/view.php?id=0002809

Deployment:
http://bugs.introversion.co.uk/view.php?id=0002920
http://bugs.introversion.co.uk/view.php?id=0002506

Game crashes:
http://bugs.introversion.co.uk/view.php?id=0002946
http://bugs.introversion.co.uk/view.php?id=0002947

More staff exhausted than exist:
http://bugs.introversion.co.uk/view.php?id=0004246
http://bugs.introversion.co.uk/view.php?id=0004245

BOT005 (done by Mazetar):
Jobs:
http://bugs.introversion.co.uk/view.php?id=0002806
http://bugs.introversion.co.uk/view.php?id=0001499

Wall won't be destroyed:
http://bugs.introversion.co.uk/view.php?id=0004145
http://bugs.introversion.co.uk/view.php?id=0004144

The dead body fall down from a ambulance - cannot be taken:
http://bugs.introversion.co.uk/view.php?id=0003176
http://bugs.introversion.co.uk/view.php?id=0003177

Crash while paused:
http://bugs.introversion.co.uk/view.php?id=0000594
http://bugs.introversion.co.uk/view.php?id=0000319

PS. @RGeezy911: I am keeping 0000101 open as it is not fully resolved.
Last edited by Reef on Thu Apr 02, 2015 11:54 pm, edited 43 times in total.

Return to “Community Members”

Who is online

Users browsing this forum: No registered users and 2 guests